DOCSP-45307: Drop external polyfill library support #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
approved these changes
Nov 14, 2024
jordan-smith721
approved these changes
Nov 14, 2024
kevinAlbs
requested review from
eramongodb
and removed request for
kevinAlbs
eramongodb
requested changes
Nov 14, 2024
eramongodb
requested changes
Nov 15, 2024
eramongodb
requested changes
Nov 19, 2024
eramongodb
approved these changes
Nov 19, 2024
source/index.txt
Outdated
|
|
||
| .. important:: | ||
|
|
||
| We recommend using the C++17 standard library whenever possible by setting the |
There was a problem hiding this comment.
Suggested change
| We recommend using the C++17 standard library whenever possible by setting the | |
| We recommend using the C++ standard library whenever possible by setting the |
Not specific to C++17; we just want users to use the C++ standard library instead of bsoncxx polyfills when able.
source/index.txt
Outdated
| @@ -37,6 +36,30 @@ Overview | |||
|
|
|||
| Welcome to the documentation site for the official {+driver-long+}. | |||
|
|
|||
| .. _cpp-polyfill-config: | |||
|
|
|||
| C++17 Polyfill Configuration | |||
There was a problem hiding this comment.
Suggest moving this section down below near "Compatibility" and "API Documentation"; it seems too high up at the moment (coming before even the "Get Started" section).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45307
Staging -
https://deploy-preview-74--docs-cpp.netlify.app/whats-new/
https://deploy-preview-74--docs-cpp.netlify.app/get-started/download-and-install/
https://deploy-preview-74--docs-cpp.netlify.app/
Self-Review Checklist